Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: accurate code comments and minor code changes #649

Merged
merged 8 commits into from
Jun 6, 2022
Merged

chore: accurate code comments and minor code changes #649

merged 8 commits into from
Jun 6, 2022

Conversation

aFlyBird0
Copy link
Member

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  1. accurate some code comments.
  2. fix some log errors, spelling errors.
  3. minor code changes.

@daniel-hutao
Copy link
Member

@aFlyBird0 Please check the ci error.

@aFlyBird0
Copy link
Member Author

@aFlyBird0 Please check the ci error.

Sorry, new code has been committed. (I ran go test ... locally before committing. /... . But I forgot that I changed the code in the configloader via GitHub pilot, thinking it was a ci test like the last one.)

@IronCore864
Copy link
Member

Very detailed change by @aFlyBird0. Thanks very much. I committed a few grammar updates in the PR directly; hope you won't mind.

Please do a regression test (for example, the GitOps process) to make sure the code change didn't break anything.

@IronCore864
Copy link
Member

@aFlyBird0 keep up the good work!

@aFlyBird0
Copy link
Member Author

Thanks for your additional commits sincerely! I will do the regression test this afternoon. @IronCore864

@daniel-hutao
Copy link
Member

@aFlyBird0 @IronCore864 How about merge this pr now. I'll test it locally today. I'm also changing the logic of the package configloader, and this pr is actually in conflict with mine. I want to merge this pr to main and then merge it to my local branch, then I resolved the conflict and continued to develop, and then tested the related functions after I finished the development.

@daniel-hutao daniel-hutao merged commit 90d0a07 into devstream-io:main Jun 6, 2022
@aFlyBird0 aFlyBird0 deleted the chore-bird-minor-changes branch June 6, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants