Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use validator for configloader validation #693

Merged

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango xu.weiKyrie@foxmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

Resolved #558

New Behavior (screenshots if needed)

None

Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mangoGoForward mangoGoForward requested a review from a team as a code owner June 20, 2022 02:40
@IronCore864
Copy link
Member

@mangoGoForward thanks for the contribution!

If you would like to continue contributing, please checkout our contributing guide doc where it tells you how to find more issues.

Please also consider joining our slack channel: join our slack channel here.

Tiexin

@IronCore864 IronCore864 merged commit 4884f46 into devstream-io:main Jun 20, 2022
@mangoGoForward mangoGoForward deleted the refactor/configloader_validate branch June 20, 2022 07:22
@mangoGoForward
Copy link
Contributor Author

@mangoGoForward thanks for the contribution!

If you would like to continue contributing, please checkout our contributing guide doc where it tells you how to find more issues.

Please also consider joining our slack channel: join our slack channel here.

Tiexin

Nice contribute experience!

@daniel-hutao
Copy link
Member

@mangoGoForward Please contact me in WeChat and I will send you a contributor certificate and a small gift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: Use Validator for Config Validation
3 participants