-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:mkdocs.md doc chinese version #708
docs:mkdocs.md doc chinese version #708
Conversation
Signed-off-by: dingweiwei <dingweiwei@admin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment below.
@Black-Gold Thanks for the pr, nice translation! There are some small suggestions I left in the review comments. Please create a new commit after local modification, and this commit should be directly pushed to your own |
/close #702 |
@Black-Gold Thanks for your contribution! We will test your change locally and try to merge it as soon as possible. Regarding commit messages, we try our best to follow the conventional commits specification so that it would give other people clear information. We've also got a "TL;DR" version in our documentation; feel free to have a quick glance. Please provide useful information in your commit message; and please do not use duplicated commit messages. You do not need to update your commit messages for this PR. We will use squash merge and update the commit messages accordingly. Please try to follow the standard next time :) |
Signed-off-by: Tiexin Guo <tiexin.guo@merico.dev>
To merge your PR quickly, I have resolved the comments and made an extra commit directly to your PR. I hope you don't mind. @Black-Gold Thanks for the contribution! |
Regarding commit messages, we try our best to follow the conventional commits specification so that it would give other people clear information. We've also got a "TL;DR" version in our documentation; feel free to have a quick glance. Please provide useful information in your commit message; and please do not use duplicated commit messages. You do not need to update your commit messages for this PR. We will use squash merge and update the commit messages accordingly. Please try to follow the standard next time :) |
Signed-off-by: dingweiwei dingweiwei@admin.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Related Issues
Closes #726
New Behavior (screenshots if needed)