Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:mkdocs.md doc chinese version #708

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

Black-Gold
Copy link
Contributor

@Black-Gold Black-Gold commented Jun 20, 2022

Signed-off-by: dingweiwei dingweiwei@admin.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

Closes #726

New Behavior (screenshots if needed)

Signed-off-by: dingweiwei <dingweiwei@admin.com>
@Black-Gold Black-Gold requested a review from IronCore864 as a code owner June 20, 2022 13:45
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment below.

@daniel-hutao
Copy link
Member

@Black-Gold Thanks for the pr, nice translation!

There are some small suggestions I left in the review comments. Please create a new commit after local modification, and this commit should be directly pushed to your own feat-dev-dingweiwei branch, it will be automatically added to this pr.

@daniel-hutao
Copy link
Member

/close #702

@IronCore864
Copy link
Member

@Black-Gold Thanks for your contribution! We will test your change locally and try to merge it as soon as possible.

Regarding commit messages, we try our best to follow the conventional commits specification so that it would give other people clear information. We've also got a "TL;DR" version in our documentation; feel free to have a quick glance. Please provide useful information in your commit message; and please do not use duplicated commit messages.

You do not need to update your commit messages for this PR. We will use squash merge and update the commit messages accordingly. Please try to follow the standard next time :)

Signed-off-by: Tiexin Guo <tiexin.guo@merico.dev>
@IronCore864
Copy link
Member

To merge your PR quickly, I have resolved the comments and made an extra commit directly to your PR. I hope you don't mind. @Black-Gold Thanks for the contribution!

@IronCore864
Copy link
Member

Regarding commit messages, we try our best to follow the conventional commits specification so that it would give other people clear information. We've also got a "TL;DR" version in our documentation; feel free to have a quick glance. Please provide useful information in your commit message; and please do not use duplicated commit messages.

You do not need to update your commit messages for this PR. We will use squash merge and update the commit messages accordingly. Please try to follow the standard next time :)

@IronCore864 IronCore864 merged commit 09b5f5c into devstream-io:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: a Chinese documentation on how to use mkdocs to write docs for DevStream
3 participants