Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: translate development-workflow into Chinese #725

Conversation

DunyuSong
Copy link
Contributor

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

#706

New Behavior (screenshots if needed)

@DunyuSong DunyuSong requested a review from IronCore864 as a code owner June 22, 2022 01:56
@IronCore864
Copy link
Member

@DunyuSong A kind reminder that you haven't signed off on your commit(s) yet.

Check out our official doc here to learn how to do this.

Licensing is important to open source projects. It provides some assurances that the software will continue to be available based on the terms that the author(s) desired.

Now that we are part of CNCF, per CNCF's requirement, we kindly require that contributors sign off on commits submitted to our project's repositories. Thanks!

@DunyuSong
Copy link
Contributor Author

I have executed "git commit --amend -s", how do I know if I have signed successfully?

@imxw
Copy link
Member

imxw commented Jun 22, 2022

I have executed "git commit --amend -s", how do I know if I have signed successfully?

git log -n1

@DunyuSong
Copy link
Contributor Author

I have signed.

@imxw
Copy link
Member

imxw commented Jun 23, 2022

I have executed "git commit --amend -s", how do I know if I have signed successfully?

after that, you need to execute git push -f origin translation_development_workflow_chinese

@IronCore864
Copy link
Member

@imxw please help the original contributor regarding signing the commit. Thanks! @daniel-hutao maybe we can demo this in the next community meeting.

@IronCore864 IronCore864 merged commit f6adfd6 into devstream-io:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants