Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mkdocs.zh.md #743

Merged
merged 3 commits into from
Jun 27, 2022
Merged

docs: mkdocs.zh.md #743

merged 3 commits into from
Jun 27, 2022

Conversation

amdaous
Copy link
Contributor

@amdaous amdaous commented Jun 23, 2022

Signed-off-by: “amdaous dreamlife1991@163.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Translate “Setting up Navigation” section in the docs/development/mkdocs.md

Related Issues

#742

New Behavior (screenshots if needed)

Signed-off-by: “amdaous <dreamlife1991@163.com>
@amdaous amdaous requested a review from IronCore864 as a code owner June 23, 2022 11:53
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0
Copy link
Member

Thank you for your initiative in submitting the issue and completing the translation! ❤️

To move things forward quickly, I have made a few changes to make the translation more accurate. I hope you don't mind!

@aFlyBird0 aFlyBird0 self-requested a review June 24, 2022 02:39
@daniel-hutao daniel-hutao requested a review from imxw June 24, 2022 06:54
docs/development/mkdocs.zh.md Outdated Show resolved Hide resolved
@imxw
Copy link
Member

imxw commented Jun 24, 2022

Thanks for your contribution! There is just a little problem left, after fixing it, I will merge the code. 😊 @amdaous

@IronCore864
Copy link
Member

Hi @amdaous,

Thanks for your contribution! We will test your change locally and try to merge it as soon as possible.

We have left a few comments, please take a look and fix them.

Please join our Slack here. Feel free to reach out and request to join the contributor channel! We are also in CNCF now; please also consider joining this channel in CNCF Slack.

In the meantime, feel free to check out our new contributor guide. We have quite a few pieces of documentation explaining the basic concepts and how to work on DevStream. Read them in the "Developer Guide" section of the documentation.

If you are searching for something else to work on, please do check out the "find an issue" section. The "help wanted" label is an excellent place to continue. If you are not completely confident yet, maybe you can warm yourself up by solving another "good first issue".

@IronCore864
Copy link
Member

@imxw please help to make sure that the contributor's PR is merged.

Signed-off-by: “amdaous <dreamlife1991@163.com>
@IronCore864 IronCore864 merged commit e549bd8 into devstream-io:main Jun 27, 2022
@amdaous amdaous deleted the feat-20220623 branch June 27, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants