Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve the robustness of e2e test local execution #763

Merged
merged 1 commit into from
Jun 28, 2022
Merged

test: improve the robustness of e2e test local execution #763

merged 1 commit into from
Jun 28, 2022

Conversation

IronCore864
Copy link
Member

@IronCore864 IronCore864 commented Jun 27, 2022 •
edited
Loading

Signed-off-by: Tiexin Guo guotiexin@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Changes:

  • update gitignore to include temporary yaml files
  • remove dead code
  • change dockerhub username in the template
  • update timeout, update default app name, fix pod readiness check bug
  • rename functions
  • improve logging

@IronCore864
test: improve the robustness of e2e test local execution
c8cd9d3 
Signed-off-by: Tiexin Guo <guotiexin@gmail.com>
@IronCore864 IronCore864 requested review from daniel-hutao and a team as code owners June 27, 2022 06:45
@IronCore864 IronCore864 requested a review from xavier-hou June 27, 2022 06:47
@IronCore864
Copy link
Member Author

@HXCGIT please have a review since you are the last guy who worked on this. Thanks in advance :)

xavier-hou
xavier-hou approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@xavier-hou xavier-hou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable Improvement. I've checked the code and test locally.

@IronCore864 IronCore864 merged commit ef59131 into main Jun 28, 2022
@IronCore864 IronCore864 deleted the test-improve-local-e2e branch June 28, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier-hou xavier-hou xavier-hou approved these changes

@daniel-hutao daniel-hutao Awaiting requested review from daniel-hutao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IronCore864 @xavier-hou