Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: referencing variables using github config #775

Merged
merged 8 commits into from
Jun 29, 2022

Conversation

KeHaohaoke
Copy link
Contributor

Signed-off-by: KeHaoKH hao.ke@merico.dev

Description

Use variables in GitHub config, not hard code in workflow file

@KeHaohaoke KeHaohaoke requested a review from daniel-hutao as a code owner June 28, 2022 03:10
@KeHaohaoke KeHaohaoke changed the title ci: Referencing variables using github config ci: referencing variables using github config Jun 28, 2022
@KeHaohaoke KeHaohaoke force-pushed the feat-cncf-license-scan branch from c7085f0 to 3cfa9a8 Compare June 28, 2022 16:35
@KeHaohaoke KeHaohaoke requested review from IronCore864 and a team as code owners June 28, 2022 16:35
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
@KeHaohaoke KeHaohaoke force-pushed the feat-cncf-license-scan branch from 317a8a0 to b8cb6e6 Compare June 28, 2022 17:28
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: fossa-contrib/fossa-action@v1
with:
# https://docs.fossa.com/docs/api-reference#push-only-api-token
fossa-api-key: c03fe407c7aa56b90b7dac1ae1868dd0
fossa-api-key: ${{ env.SECRETS_FOSSA_API_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 extra spaces here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed indent error

Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
@IronCore864 IronCore864 merged commit ffe8314 into devstream-io:main Jun 29, 2022
@IronCore864 IronCore864 deleted the feat-cncf-license-scan branch June 29, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants