-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: referencing variables using github config #775
Merged
IronCore864
merged 8 commits into
devstream-io:main
from
merico-dev:feat-cncf-license-scan
Jun 29, 2022
Merged
ci: referencing variables using github config #775
IronCore864
merged 8 commits into
devstream-io:main
from
merico-dev:feat-cncf-license-scan
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeHaohaoke
changed the title
ci: Referencing variables using github config
ci: referencing variables using github config
Jun 28, 2022
KeHaohaoke
force-pushed
the
feat-cncf-license-scan
branch
from
June 28, 2022 16:35
c7085f0
to
3cfa9a8
Compare
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
KeHaohaoke
force-pushed
the
feat-cncf-license-scan
branch
from
June 28, 2022 17:28
317a8a0
to
b8cb6e6
Compare
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
daniel-hutao
requested changes
Jun 29, 2022
.github/workflows/license-scan.yml
Outdated
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- uses: fossa-contrib/fossa-action@v1 | ||
with: | ||
# https://docs.fossa.com/docs/api-reference#push-only-api-token | ||
fossa-api-key: c03fe407c7aa56b90b7dac1ae1868dd0 | ||
fossa-api-key: ${{ env.SECRETS_FOSSA_API_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 extra spaces here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already fixed indent error
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
daniel-hutao
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KeHaoKH hao.ke@merico.dev
Description
Use variables in GitHub config, not hard code in workflow file