Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): refactor helm validate and set default timeout. #788

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

WyattJia
Copy link
Contributor

@WyattJia WyattJia commented Jun 30, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

New Behavior (screenshots if needed)

@WyattJia WyattJia requested a review from a team as a code owner June 30, 2022 05:02
@WyattJia
Copy link
Contributor Author

Refer issue #786 ,@daniel-hutao please check and review my change, and thanks.

@aFlyBird0
Copy link
Member

aFlyBird0 commented Jun 30, 2022

Hi @WyattJia , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
Here are a few useful things for you to continue your open-source journey:

A kind reminder that you haven't signed off on your commit(s) yet, which makes DCO check fail. Check out our official doc to learn how to do this.

@aFlyBird0
Copy link
Member

aFlyBird0 commented Jun 30, 2022

And I found that the commit message check failed, here is the reason. Hope it could help you. ❤️ @WyattJia

image

Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It meets the "single responsibility principle". Just go to resolve the CI failures.

@aFlyBird0 aFlyBird0 requested a review from daniel-hutao June 30, 2022 05:28
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Please fix the doc & commit message error

@WyattJia
Copy link
Contributor Author

@aFlyBird0 @daniel-hutao I've updated commite message and remove the "full stop", please help me check my change, very honored to participate in this contribution.

Signed-off-by: Wyatt Jia <i@eventloop.live>
@daniel-hutao daniel-hutao merged commit 4346803 into devstream-io:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants