-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(refactor): refactor helm validate and set default timeout. #788
Conversation
Refer issue #786 ,@daniel-hutao please check and review my change, and thanks. |
Hi @WyattJia , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
A kind reminder that you haven't signed off on your commit(s) yet, which makes DCO check fail. Check out our official doc to learn how to do this. |
And I found that the commit message check failed, here is the reason. Hope it could help you. ❤️ @WyattJia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It meets the "single responsibility principle". Just go to resolve the CI failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please fix the doc & commit message error
@aFlyBird0 @daniel-hutao I've updated commite message and remove the "full stop", please help me check my change, very honored to participate in this contribution. |
Signed-off-by: Wyatt Jia <i@eventloop.live>
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Related Issues
New Behavior (screenshots if needed)