Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update config.zh.md #803

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Conversation

NUCsimple
Copy link
Contributor

Signed-off-by: 高强 qiang.gao@yeepay.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

New Behavior (screenshots if needed)

Signed-off-by: 高强 <qiang.gao@yeepay.com>
@NUCsimple NUCsimple requested a review from IronCore864 as a code owner July 3, 2022 14:11
    Signed-off-by: Tiexin Guo <guotiexin@gmail.com>
@IronCore864
Copy link
Member

Hi @NUCsimple, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

We made changes to your PR directly so that your contribution can be merged quicker. We hope you don't mind!

In this PR, there are a few issues worth noting:

  • spaces between Chinese and English: either have them all or not have a single one of them. The key is to be consistent.
  • some English words or even sentences are not translated.
  • spelling: we need to keep proper nouns consistent with their official names. I.E., Yaml V.S. YAML.

Please pay closer attention in your next PR:)

Also, for translation documentation, you need to create an issue and discuss it with our community first before working on it.

@IronCore864 IronCore864 merged commit e445993 into devstream-io:main Jul 4, 2022
@xavier-hou
Copy link
Member

@NUCsimple Really appreciate your contribution! Have you joined our WeChat contributors group? If not, please contact me on the devstream WeChat group(search LBJ) and I will invite you to the contributors group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants