Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improving The Robustness of Config File #805

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

byene0923
Copy link
Contributor

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Improving The Robustness of Config File

  • judge core config by key core
  • judge tool config by key tools

Related Issues

#659

New Behavior (screenshots if needed)

@byene0923 byene0923 requested a review from a team as a code owner July 3, 2022 15:26
@xavier-hou
Copy link
Member

Hi @byene0923 , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

A kind reminder that you haven't signed off on your commit(s) yet. Check out our official doc to learn how to do this.

Also, DevStream community follows the conventional commits specification. Please read our doc and update your commit message.

  • It seems that you shoud put a space after feat:.

@xavier-hou xavier-hou self-requested a review July 4, 2022 03:20
Signed-off-by: byene0923 <byene0923@gmail.com>
@byene0923 byene0923 changed the title feat:Improving The Robustness of Config File feat: Improving The Robustness of Config File Jul 4, 2022
@byene0923
Copy link
Contributor Author

ohh, thanks a lot for your review. i fix it

Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👏

@aFlyBird0 aFlyBird0 assigned xavier-hou and unassigned aFlyBird0 Jul 5, 2022
@aFlyBird0 aFlyBird0 merged commit af49f3f into devstream-io:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants