Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default repo config for argo #851

Closed
wants to merge 1 commit into from

Conversation

homily707
Copy link
Contributor

@homily707 homily707 commented Jul 13, 2022

Signed-off-by: homily707 homily707@outlook.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

add default repo name and url config for argo

Related Issues

#514

New Behavior (screenshots if needed)

@homily707 homily707 requested a review from a team as a code owner July 13, 2022 16:34
Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @homily707 , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

We made changes to your PR directly so that your contribution can be merged quicker. We hope you don't mind!

internal/pkg/plugin/argocd/validate.go Outdated Show resolved Hide resolved
internal/pkg/plugin/argocd/argocd.go Outdated Show resolved Hide resolved
Signed-off-by: homily707 <homily707@outlook.com>
@homily707 homily707 force-pushed the argocd_enhancemnet branch from 7e94081 to 117fad9 Compare July 14, 2022 14:04
@homily707 homily707 closed this Jul 14, 2022
@homily707 homily707 deleted the argocd_enhancemnet branch July 14, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants