Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support helm plugin default value #936

Merged
merged 3 commits into from
Aug 5, 2022
Merged

feat: support helm plugin default value #936

merged 3 commits into from
Aug 5, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Aug 3, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • plugin argocd support default value config
  • add unit test for helm installer
  • all helm options add mapstructure field name
  • helm validate func not execute default logic

Related Issues

#514

New Behavior (screenshots if needed)

@steinliber
feat: support helm plugin default value
6c5dba3 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested review from IronCore864 and a team as code owners August 3, 2022 06:57
@steinliber
fix: repair name error
044c8f3 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from iyear August 3, 2022 07:38
iyear
iyear reviewed Aug 3, 2022
View reviewed changes
pkg/util/helm/helm.go Outdated Show resolved Hide resolved
iyear
iyear approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant Impl! Users will have a better idea of what they need to fill in.

@steinliber
fix: ues bool type
d001f0f 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from a team August 3, 2022 08:56
@daniel-hutao daniel-hutao assigned IronCore864 and unassigned iyear Aug 3, 2022
aFlyBird0
aFlyBird0 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/plugins/argocd.md Show resolved Hide resolved
@IronCore864 IronCore864 merged commit b3ba2c5 into devstream-io:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyear iyear iyear approved these changes

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

@IronCore864 IronCore864 IronCore864 approved these changes

Assignees

@IronCore864 IronCore864

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steinliber @IronCore864 @aFlyBird0 @iyear