docs: update plugin list #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bird <aflybird0@gmail.com>
steinliber
approved these changes
Aug 7, 2022
daniel-hutao
requested changes
Aug 7, 2022
| @@ -133,8 +133,8 @@ tools: | |||
| # release name of the jenkins helm chart, mandatory | |||
| releaseName: | |||
| # GitHub repo where to put the pipeline script and project. mandatory | |||
| githubRepoUrl: https://github.com/aFlyBird0/jenkins-file-test | |||
| githubRepoUrl: https://github.com/xxx/xxx | |||
There was a problem hiding this comment.
Maybe it is better to use some placeholder like YOUR_GITHUB_ACCOUNT/YOUR_TEST_PROJECT_NAME here.
There was a problem hiding this comment.
True, but this tends to trigger bad links checks. Maybe we could add a . *YOUR.* link ignore rule?
There was a problem hiding this comment.
True, but this tends to trigger bad links checks. Maybe we could add a
. *YOUR.*link ignore rule?
Oh, I got it. Let me merge this pr first. And I think it's ok to add .*YOUR_.* ignore rule. @aFlyBird0
iyear
approved these changes
Aug 8, 2022
Signed-off-by: Bird <aflybird0@gmail.com>
daniel-hutao
approved these changes
Aug 8, 2022
daniel-hutao
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bird aflybird0@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Changes