Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: all repo use same logic #966

Merged
merged 1 commit into from
Aug 9, 2022
Merged

refactor: all repo use same logic #966

merged 1 commit into from
Aug 9, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Aug 8, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • all repo config use the same struct
  • put github, gitlab logic in pkg/util
  • gitops has been tested

New Behavior (screenshots if needed)

image

@steinliber steinliber requested a review from a team as a code owner August 8, 2022 07:07
iyear
iyear approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More clear code!

@aFlyBird0 aFlyBird0 self-assigned this Aug 9, 2022
@steinliber @steinsmf
refactor: all repo use same logic
a9a49a7 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the refactor-common-repo branch from ecd8efe to a9a49a7 Compare August 9, 2022 05:32
daniel-hutao
daniel-hutao approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao daniel-hutao merged commit 8fc89d9 into devstream-io:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyear iyear iyear approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees

@aFlyBird0 aFlyBird0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steinliber @daniel-hutao @iyear @aFlyBird0