Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(LSC): replace deprecated functions under pkg io/ioutil #970

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

xinqshang
Copy link

@xinqshang xinqshang commented Aug 9, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

golangci-lint report some err when exec make all
to fix it
replace deprecated functions under pkg io/ioutil

Related Issues

N/A

New Behavior (screenshots if needed)

N/A

xinqshang added 3 commits August 9, 2022 15:02
Signed-off-by: xinqshang <xinqi.shang@dhc.com.cn>
Signed-off-by: xinqshang <xinqi.shang@dhc.com.cn>
@xinqshang xinqshang requested a review from a team as a code owner August 9, 2022 08:27
@daniel-hutao
Copy link
Member

I'm so sorry that this branch has conflicts for my previous merged refactor pr. Please resolve the conflicts and then, we'll take a review right away.

@aFlyBird0
Copy link
Member

Hi @xinqshang , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

We will review your pr tomorrow morning.🙌

@iyear
Copy link
Member

iyear commented Aug 10, 2022

@xinqshang If you find it difficult to resolve a large number of conflicts and the code submitted is not too difficult to modify, you can close the PR first, sync fork and then submit a new PR again.

@xinqshang
Copy link
Author

I'm so sorry that this branch has conflicts for my previous merged refactor pr. Please resolve the conflicts and then, we'll take a review right away.

done

@xinqshang
Copy link
Author

Hi @xinqshang , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

We will review your pr tomorrow morning.🙌

got it

Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful Gopher🐭!

@daniel-hutao daniel-hutao self-requested a review August 10, 2022 08:07
@daniel-hutao daniel-hutao merged commit b669039 into devstream-io:main Aug 10, 2022
@iyear iyear mentioned this pull request Aug 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants