-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(LSC): replace deprecated functions under pkg io/ioutil #970
Conversation
Signed-off-by: xinqshang <xinqi.shang@dhc.com.cn>
Signed-off-by: xinqshang <xinqi.shang@dhc.com.cn>
I'm so sorry that this branch has conflicts for my previous merged refactor pr. Please resolve the conflicts and then, we'll take a review right away. |
Hi @xinqshang , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack! Here are a few useful things for you to continue your open-source journey:
We will review your pr tomorrow morning.🙌 |
@xinqshang If you find it difficult to resolve a large number of conflicts and the code submitted is not too difficult to modify, you can close the PR first, sync fork and then submit a new PR again. |
done |
got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful Gopher🐭!
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
golangci-lint report some err when exec make all
to fix it
replace deprecated functions under pkg io/ioutil
Related Issues
N/A
New Behavior (screenshots if needed)
N/A