-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: protect branch when init github repo #973
feat: protect branch when init github repo #973
Conversation
Signed-off-by: csonezp <csonezp@gmail.com>
@csonezp Thank you so much for the contribution, it's an enhancement to github package! You can change it to |
Signed-off-by: csonezp <csonezp@gmail.com>
@iyear Issues mentioned in the conversation have been resolved. |
Signed-off-by: csonezp <csonezp@gmail.com>
Signed-off-by: csonezp <csonezp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature!
We advocate combining similar content from one PR into one commit, see our blog post for details. Of course for initial contributors, this is not required. You can take note of this the next time you submit a PR. |
@iyear In other open source projects I have participated in, the step of squashing commits is done by project members who merge PR, and I didn't find any instructions for squash in the contributor guide, so I keep multiple commits to preserve the review context. We can add this requirement to the contributor guidelines to prevent other contributors from not knowing this information |
@csonezp Thank you for the reminder, I will discuss this matter within members. |
Signed-off-by: csonezp csonezp@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
repo-scaffolding should protect the default main branch.
I'm not used to using ginkgo, so the test cases may not be well designed, If you find any problem please submit some suggestions
Related Issues
Closes #963
New Behavior (screenshots if needed)
When use repo-scaffolding to create destination repo, protected the default branch.