Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Some Naming and Comments are Updated According the plugininstaller Refactoring #976

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Some naming and comments are updated according the plugininstaller refactoring

Related Issues

N/A

New Behavior (screenshots if needed)

N/A

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao requested a review from a team as a code owner August 10, 2022 07:25
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that it's all name and comment changes, and if it compiles locally it means passes.

@iyear iyear merged commit b860e76 into devstream-io:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants