-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: all files about templates and kubectl #994
Conversation
ba93873
to
783268f
Compare
3bd6e94
to
2ae7ea4
Compare
Signed-off-by: Bird <aflybird0@gmail.com>
2ae7ea4
to
6e9380c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this refactor is great and more clear, you should add more test in pkg/util/template beacuse many func will invoke this module
Thank you for your review and suggestion. I will add more uts as possible as I can. |
Signed-off-by: Bird <aflybird0@gmail.com>
bd0528a
to
7acff8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bird aflybird0@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
template
related code from/internal/pkg/file
to/pkg/util/template
template
package, see the code comments in/pkg/util/template
for detailstemplate
packagekubectl
package to include theinstaller
andutil
parts.New Behaviors
1. template
2. kubectl