Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: all files about templates and kubectl #994

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Aug 15, 2022

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  1. move the template related code from /internal/pkg/file to /pkg/util/template
  2. refactor the template package, see the code comments in /pkg/util/template for details
  3. Modify all related code in the project to use the new template package
  4. refactor the kubectl package to include the installer and util parts.

New Behaviors

1. template

image

image

2. kubectl

image

image

image

image

image

image

@aFlyBird0 aFlyBird0 requested a review from a team as a code owner August 15, 2022 19:04
@aFlyBird0 aFlyBird0 force-pushed the refactor-template branch 2 times, most recently from ba93873 to 783268f Compare August 15, 2022 19:34
pkg/util/file/github.go Outdated Show resolved Hide resolved
@aFlyBird0 aFlyBird0 force-pushed the refactor-template branch 5 times, most recently from 3bd6e94 to 2ae7ea4 Compare August 15, 2022 20:19
Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this refactor is great and more clear, you should add more test in pkg/util/template beacuse many func will invoke this module

internal/pkg/configmanager/variables.go Outdated Show resolved Hide resolved
@aFlyBird0
Copy link
Member Author

I think this refactor is great and more clear, you should add more test in pkg/util/template beacuse many func will invoke this module

Thank you for your review and suggestion. I will add more uts as possible as I can.

Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steinliber steinliber merged commit c93d391 into devstream-io:main Aug 16, 2022
@aFlyBird0 aFlyBird0 deleted the refactor-template branch August 22, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants