Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #188 : add highlighte/active status to tag when user filter. #190

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

MohitKambli
Copy link
Contributor

Hello,
Hope you're doing well.
As it has been requested in issue #188, I have added the necessary code for highlighting the selected tag on the main page.
This highlight is red in color that would surround the selected tag.
Hope these code changes meet the requirements.
If at all you find any issues from my end or any incorrect behaviour in the application, then kindly let me know.
Sincere apologies for the same if you find any mistakes.
Thank you for understanding.

Regards,
Mohit Kambli

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-error-solve ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 4:11pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, MohitKambli! 🎉 Thank you for submitting your first pull request to GES. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!

Copy link
Owner

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Instead of using a new state for the tag, you could use the type state by passing it to the SearchInput component from home component.

@devvsakib devvsakib merged commit ff5a1e5 into devvsakib:main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants