Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #163

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Remove warnings #163

merged 3 commits into from
Jun 20, 2023

Conversation

OhKanghoon
Copy link
Collaborator

No description provided.

Non-'@objc' class method in extensions cannot be overridden; use 'public' instead
@OhKanghoon OhKanghoon self-assigned this Jun 20, 2023
@OhKanghoon OhKanghoon force-pushed the feature/remove-warning branch 3 times, most recently from e6f7d08 to 73b569d Compare June 20, 2023 16:59
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.34 🎉

Comparison is base (18ba61f) 94.04% compared to head (9f0a30d) 94.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   94.04%   94.39%   +0.34%     
==========================================
  Files           7        7              
  Lines         235      321      +86     
==========================================
+ Hits          221      303      +82     
- Misses         14       18       +4     
Impacted Files Coverage Δ
Sources/URLMatcher/URLConvertible.swift 100.00% <ø> (+3.70%) ⬆️
...gator/UIViewController+TopMostViewController.swift 65.30% <50.00%> (+5.93%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OhKanghoon OhKanghoon merged commit 8078e3a into master Jun 20, 2023
2 checks passed
@OhKanghoon OhKanghoon deleted the feature/remove-warning branch June 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant