Skip to content

Commit

Permalink
chore: Add a comment about config/email JSON tag bug (#2830)
Browse files Browse the repository at this point in the history
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
  • Loading branch information
nabokihms authored Feb 16, 2023
1 parent 7016a82 commit e2ce0b6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions storage/storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,10 @@ type Connector struct {
ResourceVersion string `json:"resourceVersion"`
// Config holds all the configuration information specific to the connector type. Since there
// no generic struct we can use for this purpose, it is stored as a byte stream.
//
// NOTE: This is a bug. The JSON tag should be `config`.
// However, fixing this requires migrating Kubernetes objects for all previously created connectors,
// or making Dex reading both tags and act accordingly.
Config []byte `json:"email"`
}

Expand Down

0 comments on commit e2ce0b6

Please sign in to comment.