Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of json field #1424

Closed
wants to merge 1 commit into from
Closed

Conversation

simonswine
Copy link

Not too sure of the impact of this, just a problem I saw navigating through the code

Signed-off-by: Christian Simon <simon@swine.de>
@srenatus
Copy link
Contributor

💭 If you've got an existing config stored under the (wrong) email key, it wouldn't be read back properly by a version of dex with this fix applied, would it? I suppose this case needs some extra handling. Not sure it's worth the hassle, though... 😉

@ericchiang
Copy link
Contributor

ericchiang commented Apr 15, 2019 via email

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this instead 😉 #1424 (comment) -- What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants