Remove google specific hd / hosted domain claim config from oidc connector #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Brandelli <abrandel@cisco.com>
cisco-abrandel
changed the title
nabokihms
approved these changes
May 13, 2022
|
We should not forget to mention this in the upper block of the release message. |
cisco-abrandel
added a commit
to cisco-abrandel/website
that referenced
this pull request
May 13, 2022
…ed from this connector in dexidp/dex#2511 Signed-off-by: Anthony Brandelli <abrandel@cisco.com>
kerberos727
added a commit
to kerberos727/dex-project
that referenced
this pull request
Aug 23, 2024
…ed from this connector in dexidp/dex#2511 Signed-off-by: Anthony Brandelli <abrandel@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony Brandelli abrandel@cisco.com
Overview
At some point in the evolution of dex it seems like some Google specific stuff got left in the OIDC connector, when there is now a Google specific one.
I would like to gather feedback on this PR whether it makes sense to remove this, given that there could be users out there who are utilizing the OIDC connector but using Google as their IDP, instead of using the Google connector. I don't want to break people, but I also think this stuff is pretty
What this PR does / why we need it
Special notes for your reviewer
Originally added in #974 which is before the Google connector was split out here #1185. I believe that this is just a miss since then, I am unaware of any other IDPs (but of course I am not aware of everyone's configuration) that use this claim.
This is currently also referenced in the docs here https://dexidp.io/docs/connectors/oidc/, I will open a separate PR to update the docs should it be agreed we want to proceed with removing this code.
Does this PR introduce a user-facing change?