fix: refresh token only once for all concurrent requests #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabokihms
force-pushed
the
refresh-once
branch
from
f3babca
to
49fbc5c
Compare
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
force-pushed
the
refresh-once
branch
from
49fbc5c
to
4b5f1d5
Compare
sagikazarmark
approved these changes
Oct 3, 2022
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Oct 3, 2022
**⚠️ This release fixes a [major vulnerability](GHSA-vh7g-p26c-j2cw) in Dex. We advise everyone to upgrade as soon as possible!⚠️ ** The official container image for this release can be pulled from ``` ghcr.io/dexidp/dex:v2.35.0 ``` <!-- Release notes generated using configuration in .github/release.yml at v2.35.0 --> ## What's Changed ### Enhancements 🚀 * Reduce HTTP client creations in the Keystone connector by @erwinvaneyk in dexidp#2659 ### Bug Fixes 🐛 * fix for issue 2670; check for no serviceAccountFilePath and no email by @bobcallaway in dexidp#2679 * supply HMACKey in test case by @bobcallaway in dexidp#2683 * fix: refresh token only once for all concurrent requests by @nabokihms in dexidp#2692 ### Dependency Updates ⬆️ * build(deps): bump google.golang.org/api from 0.95.0 to 0.97.0 by @dependabot in dexidp#2677 * build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.4 to 3.5.5 by @dependabot in dexidp#2666 * build(deps): bump google.golang.org/api from 0.97.0 to 0.98.0 by @dependabot in dexidp#2682 * build(deps): bump helm/kind-action from 1.3.0 to 1.4.0 by @dependabot in dexidp#2681 * build(deps): bump entgo.io/ent from 0.11.2 to 0.11.3 by @dependabot in dexidp#2684 * Update golang.org/x packages by @sagikazarmark in dexidp#2688 ## New Contributors * @jannfis made their first contribution in dexidp#2691 **Full Changelog**: dexidp/dex@v2.34.0...v2.35.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: m.nabokikh maksim.nabokikh@flant.com
Overview
This PR moves the external provider refresh call to the transaction. If the underlying Dex storage has a proper locking mechanism, in combination with the
reuseIntervaloption for all concurrent requests, Dex will call refresh for an external provider only once.What this PR does / why we need it
Closes #2547
Special notes for your reviewer
Does this PR introduce a user-facing change?