Remove stale caveat that indicates changed upstream claims won't be sent downstream from dex #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent downstream from dex Signed-off-by: Anthony Brandelli <abrandel@cisco.com>
nabokihms
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caveat seems to be stale. It references dexidp/dex#863, which was closed in dexidp/dex#1180. Looking at the PR this does seem to propagate the upstream claims downstream on refresh, and in my (albeit limited) testing changed claims do come down in the dex ID token.
Possible I'm incorrect here, but as far as I can see this is just a doc bug and the actual functionality has been there for a while.
Signed-off-by: Anthony Brandelli abrandel@cisco.com