This repository has been archived by the owner on Jul 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wcarlsen
commented
Apr 29, 2022
- Install confluent cli tool instead of the soon to be EOL ccloud cli
- Changed entrypoint login scripts and updated cli executable to confluent
- Updated CcloudCluster class and changed parsing to utilize json
- Alter list topics to utilize json output
- Alter describe topics to utilize json output
- Alter list service-accounts to utilize json output
- use list service-account
- Alter create service-accounts to utilize json output
- Alter api-keys to utilize json output
- Alter acls to utilize json output
- Convert ACL UserId from long to string, to make it clear that it is not in use
- Convert ACL serviceAccountId from long to string
CodeScene Delta Analysis ResultsView detailed results in CodeScene
Review of New Files0 new file(s) below the threshold for new code (9). |
jdsmithit
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a good chance to look at adding a read me file?
SEQUOIIA
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love me some Confluent CLI updates. Weee.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.