Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #34

Merged
merged 6 commits into from
Mar 15, 2016
Merged

Testing #34

merged 6 commits into from
Mar 15, 2016

Conversation

rofinn
Copy link
Contributor

@rofinn rofinn commented Mar 15, 2016

Adds basic test harness functions and some minor changes to the existing code bases.

NOTE: test cases have been updated to use the test harness functions.

…s of the functions with the same name was causing the problem.
1. The test and benchmark function in the pkg now reduce the amount of code
   in the pkg test cases.
2. Removed unnecessary parameters from functions to make the new test cases
   work, but also better adheres to "Don’t use unnecessary static parameters"
   and "Avoid writing overly-specific types" in the [julia style guide](http://docs.julialang.org/en/release-0.4/manual/style-guide/)
1. reduced testing time by limiting the size of rbms and iterations needed for test and benchmark calls.
2. fixed issue in Boltzmann.test where AbstractArray attributes in an RBM weren't being found correctly.
3. added some tests of test.jl functions in testutils.jl, since these aren't run with coverage on travis.
@codecov-io
Copy link

Current coverage is 87.25%

Merging #34 into master will increase coverage by +5.99% as of a502fd1

@@            master     #34   diff @@
======================================
  Files            6       8     +2
  Stmts          395     510   +115
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            321     445   +124
  Partial          0       0       
+ Missed          74      65     -9

Review entire Coverage Diff as of a502fd1

Powered by Codecov. Updated on successful CI builds.

@dfdx
Copy link
Owner

dfdx commented Mar 15, 2016

Great work, thanks a lot! I think we can now close both - #28 and #30.

dfdx added a commit that referenced this pull request Mar 15, 2016
@dfdx dfdx merged commit 83353a5 into dfdx:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants