chore(PocketIC): use sequence numbers as state labels #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
changed the title
This reverts commit 49e0f0b.
This reverts commit 20a51ba.
michael-weigelt
approved these changes
Oct 25, 2024
nmattia
pushed a commit
that referenced
this pull request
Oct 25, 2024
This PR replaces a state label derived from the certified state by a sequence number. The reason for this change is that parts of a PocketIC instance state are not certified (e.g., ingress and canister http pools) and thus they are not reflected in the state label. Because it is not clear why having the same state label for two different instances with the same state would be beneficial at the moment, this PR uses sequence numbers as state labels. This PR also fixes a bug when deleting an instance: an instance should not be deleted if it is still busy with a computation. Finally, - the size of the test `//packages/pocket-ic:test` is reduced back to small (this test is fast again); - outdated comments are removed; - unnecessary Debug implementations are removed. --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a state label derived from the certified state by a sequence number. The reason for this change is that parts of a PocketIC instance state are not certified (e.g., ingress and canister http pools) and thus they are not reflected in the state label. Because it is not clear why having the same state label for two different instances with the same state would be beneficial at the moment, this PR uses sequence numbers as state labels.
This PR also fixes a bug when deleting an instance: an instance should not be deleted if it is still busy with a computation.
Finally,
//packages/pocket-ic:testis reduced back to small (this test is fast again);