Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Make CI PR Only mandatory for PRs #2796

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

venkkatesh-sekar
Copy link
Member

@venkkatesh-sekar venkkatesh-sekar commented Nov 25, 2024

This PR is a necessary step before making CI PR Only required / mandatory on PRs.

Currently, when a workflow is marked as required for PR, it is also enforced on the merge queue as well which can block the queue. However, these jobs are only needed to gate the merge. Hence, we allow the workflow to run on merge_group but each individual job is not run by adding if: ${{ github.event_name != 'merge_group' }}

@github-actions github-actions bot added the chore label Nov 25, 2024
@venkkatesh-sekar venkkatesh-sekar marked this pull request as ready for review November 25, 2024 13:22
@venkkatesh-sekar venkkatesh-sekar requested a review from a team as a code owner November 25, 2024 13:22
@github-actions github-actions bot added the @idx label Nov 25, 2024
@venkkatesh-sekar venkkatesh-sekar added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 73c1a5e Nov 25, 2024
29 checks passed
@venkkatesh-sekar venkkatesh-sekar deleted the vsekar/mark-ci-pr-required branch November 25, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants