chore: Name canister sandbox reader threads #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an explicit name, they end up named "MR Batch Processor", same as the Message Routing thread. Or at least the CPU profiler gets confused enough to bundle them with the DSM thread. This results in confusing CPU profiles.
|
Sample confusing CPU profile: |
adambratschikaye
approved these changes
Dec 19, 2024
rs/canister_sandbox/src/replica_controller/launch_as_process.rs
Outdated
Show resolved
Hide resolved
rs/canister_sandbox/src/replica_controller/launch_as_process.rs
Outdated
Show resolved
Hide resolved
|
All done. Thanks a lot for suggesting better names. I was going to ask for more appropriate ones, but then got carried away with other stuff and forgot. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alin-at-dfinity
deleted the
alin/name-canister-sandbox-reader-threads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an explicit name, they end up named "MR Batch Processor", same as the Message Routing thread. Or at least the CPU profiler gets confused enough to bundle them with the DSM thread. This results in confusing CPU profiles.