Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rust-toolchain.toml file #225

Merged
merged 4 commits into from
May 7, 2021
Merged

add rust-toolchain.toml file #225

merged 4 commits into from
May 7, 2021

Conversation

roman-kashitsyn
Copy link
Contributor

This change introduces a rust-toolchain file that instructs rustup to
use the right version of Rust tooling for the project. See
https://rust-lang.github.io/rustup/overrides.html for more details.

This change introduces a rust-toolchain file that instructs rustup to
use the right version of Rust tooling for the project.  See
https://rust-lang.github.io/rustup/overrides.html for more details.
@roman-kashitsyn roman-kashitsyn requested a review from nomeata May 6, 2021 15:24
@nomeata
Copy link
Contributor

nomeata commented May 6, 2021

With this in place, we can probably simplify installing rust in the CI scripts, and deduplicate the information which version to use

@nomeata
Copy link
Contributor

nomeata commented May 6, 2021

So is there an equivalent to

          rustup update ${{ matrix.rust }} --no-self-update
          rustup default ${{ matrix.rust }}
          rustup target add wasm32-unknown-unknown

that reads the version and target list from this file?

@nomeata
Copy link
Contributor

nomeata commented May 6, 2021

No, currently not supported, it seems: rust-lang/rustup#2686

@roman-kashitsyn
Copy link
Contributor Author

With this in place, we can probably simplify installing rust in the CI scripts, and deduplicate the information which version to use

Would be nice, but it's indeed not yet supported. This file mostly useful for local development ATM. It instructs rustup to pick the right version and install the targets automatically. The intention is to reduce friction when onboarding new people or upgrading the compiler.

@nomeata nomeata enabled auto-merge (squash) May 7, 2021 09:31
@nomeata nomeata merged commit a7e3a36 into main May 7, 2021
@nomeata nomeata deleted the roman/rust-toolchain branch May 7, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants