Skip to content

Commit

Permalink
changelog and docs;
Browse files Browse the repository at this point in the history
  • Loading branch information
ericswanson-dfinity committed Aug 26, 2024
1 parent 5a4ab3b commit 2237ac4
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ on:
push:
branches:
- master
- ens/sdk-1814-set-cwd-for-scripts
pull_request:

concurrency:
Expand Down
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@

`dfx start --pocketic` no longer requires `--clean`, and can persist replica state between runs.

### fix: Scripts always run with current directory set to the project root

Build scripts and other scripts now always run with the working directory
set to the project root (directory containing dfx.json).

This applies to the following:
- build scripts
- extension run
- tech stack value computation
- packtool (vessel, mops etc)

# 0.23.0

### feat: Add canister snapshots
Expand Down
6 changes: 3 additions & 3 deletions docs/dfx-json-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
"properties": {
"build": {
"title": "Build Commands",
"description": "Commands that are executed in order to produce this canister's Wasm module. Expected to produce the Wasm in the path specified by the 'wasm' field. No build commands are allowed if the `wasm` field is a URL.",
"description": "Commands that are executed in order to produce this canister's Wasm module. Expected to produce the Wasm in the path specified by the 'wasm' field. No build commands are allowed if the `wasm` field is a URL. These commands are executed in the root of the project.",
"default": [],
"allOf": [
{
Expand Down Expand Up @@ -467,7 +467,7 @@
},
"post_install": {
"title": "Post-Install Commands",
"description": "One or more commands to run post canister installation.",
"description": "One or more commands to run post canister installation. These commands are executed in the root of the project.",
"default": [],
"allOf": [
{
Expand Down Expand Up @@ -698,7 +698,7 @@
]
},
"packtool": {
"description": "Main command to run the packtool.",
"description": "Main command to run the packtool. This command is executed in the root of the project.",
"type": [
"string",
"null"
Expand Down
3 changes: 3 additions & 0 deletions src/dfx-core/src/config/model/dfinity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ pub struct ConfigCanistersCanister {

/// # Post-Install Commands
/// One or more commands to run post canister installation.
/// These commands are executed in the root of the project.
#[serde(default)]
pub post_install: SerdeVec<String>,

Expand Down Expand Up @@ -379,6 +380,7 @@ pub enum CanisterTypeProperties {
/// Commands that are executed in order to produce this canister's Wasm module.
/// Expected to produce the Wasm in the path specified by the 'wasm' field.
/// No build commands are allowed if the `wasm` field is a URL.
/// These commands are executed in the root of the project.
#[schemars(default)]
build: SerdeVec<String>,
},
Expand Down Expand Up @@ -617,6 +619,7 @@ impl Default for ConfigDefaultsBootstrap {
#[derive(Clone, Debug, Default, Serialize, Deserialize, JsonSchema)]
pub struct ConfigDefaultsBuild {
/// Main command to run the packtool.
/// This command is executed in the root of the project.
pub packtool: Option<String>,

/// Arguments for packtool.
Expand Down

0 comments on commit 2237ac4

Please sign in to comment.