feat: install extensions using the catalog #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look up extension.json url from /catalog.json in https://github.com/dfinity/dfx-extensions Fixes https://dfinity.atlassian.net/browse/SDK-1796
ericswanson-dfinity
changed the title
| @@ -23,6 +22,9 @@ pub struct InstallOpts { | |||
| /// Installs a specific version of the extension, bypassing version checks | |||
| #[clap(long)] | |||
| version: Option<Version>, | |||
| /// Specifies the URL of the catalog to use to find the extension. | |||
| #[clap(long)] | |||
| catalog_url: Option<Url>, | |||
There was a problem hiding this comment.
Maybe this should be catalog
lwshang
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Look up location of extension.json url from /catalog.json in https://github.com/dfinity/dfx-extensions
Fixes https://dfinity.atlassian.net/browse/SDK-1796
How Has This Been Tested?
Added an e2e test, and the
dfx extension install <extension name>test also covers this.Checklist: