Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change placeholder format to use underscores #3900

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

This PR eliminates the difference between file path placeholders and within-file placeholders - both are now __var__.
This works around rust-lang/cargo#13724 where {} in the package name causes an error as of 1.77, but also fixes the JS files to stop having syntax errors and confusing prettier.js.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review September 3, 2024 18:58
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner September 3, 2024 18:58
@adamspofford-dfinity adamspofford-dfinity enabled auto-merge (squash) September 3, 2024 19:35
@adamspofford-dfinity adamspofford-dfinity merged commit 77164f9 into master Sep 3, 2024
296 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/template-ident branch September 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants