Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest finalization #597

Merged
merged 60 commits into from
Sep 27, 2024
Merged

Rest finalization #597

merged 60 commits into from
Sep 27, 2024

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Sep 25, 2024

This closes #537.

  • ensured object return types are uniform across all iocs endpoints with accompanying backend tests
  • ensured object return types are uniform across all assets endpoints with accompanying backend tests
  • Added some more e2e tests
  • use only absolute urls in web interface
  • use template literals for urls in web interface

@c8y3
[IMP] Simple quotes
d08e6fe
@c8y3
[IMP] Simple quotes
2428735
@c8y3
[IMP] More succinct code
34ea713
@c8y3
[IMP] Added TODO
068e608
@c8y3
[IMP] Renamed test
af29302
@c8y3
[IMP] Added tlp field directly on the new IOCSchemaForAPIV2
1d525d8
@c8y3
[IMP] Removed unused parameter caseid
e745a4c
@c8y3
[IMP] iocs link field is directly incorporated in the schema
98edea7
@c8y3
[IMP] Added TODO
05752e4
@c8y3
[IMP] Added field link on response of POST /api/v2/cases/{identifier}…
42f052b 
…/iocs
@c8y3
[IMP] Added field link on response of GET /api/v2/iocs/{identifier}
f26c3b2
@c8y3
[IMP] Use same schema for response of GET /api/v2/assets/{identifier}…
371b9cc 
… and POST /api/v2/cases/{identifier}/assets
@c8y3
[IMP] Removed seemingly dead method
be94f42
@c8y3
[IMP] Use absolute urls rather than relative
1abaaa3
@c8y3
[IMP] Use absolute url in ui instead of relative. Added test.
43732e4
@c8y3
[IMP] Added test on creation of template
dd36993
@c8y3
[IMP] path.join unnecessary
52c6923
@c8y3
[IMP] Using absolute path in interface to access /manage/customers/list
82772c5
@c8y3
[IMP] command to record e2e tests
773b3d2
@c8y3
[IMP] Use template literal
1ae6835
@c8y3
[IMP] Using template literal for url
55d269f
@c8y3
[IMP] Using template literal for urls
80f019e
@c8y3
[IMP] Using template literal for urls
cade704
@c8y3
[IMP] Using absolute path for url
f3d8a6a
@c8y3
[IMP] Using absolute path for url
58354e1
@c8y3
[IMP] Using template literal for urls
0286fa2
@c8y3
[IMP] Using absolute path for url
a0121d2
@c8y3
[IMP] Using template literal for urls
df100ce
@c8y3
[IMP] Simple quotes
fde05cc
@c8y3
[IMP] Using template literal for url
c35bbf9
@c8y3
[IMP] Using absolute path for url
ca7f6ed
@c8y3
[IMP] Inlined method
6d6b660
@c8y3
[IMP] Using template literal
8ec551e
@c8y3
[IMP] Using template literal
02d9a9f
@c8y3
[IMP] Using absolute path for url
4e7754c
@c8y3
[IMP] Using absolute path for url
412434b
@c8y3
[IMP] Using absolute path for url
ddce959
@c8y3
[IMP] Using template literal
83b89ff
@c8y3
[IMP] Using template literal
3bbf2b2
@c8y3
[IMP] Using absolute path for url
ab5d93f
@c8y3
[IMP] Using template literal
ccc2a44
@c8y3
[IMP] Using template literal
991399e
@c8y3
[IMP] Using template literal
2b02fd7
@c8y3
[IMP] Using template literal for urls
f793eeb
@c8y3
[IMP] Using template literal for urls
0f243ce
@c8y3
[IMP] Removed unnecessary variables
4d96f67
@c8y3
[IMP] Using template literal for url
cbf6e98
@c8y3
[IMP] Using absolute path for url
3d1b992
@c8y3
[IMP] Using template literal for urls
c42e293
@c8y3
[IMP] Using absolute path for url
c0f6639
@c8y3
[IMP] Using absolute path for url
d76a821
@c8y3
[IMP] Using template literal for urls
e2c6629
@c8y3
[IMP] Using template literal for urls
6911a21
@c8y3
[IMP] Using template literal for urls
984e719
@c8y3 c8y3 added enhancement New feature or request quality labels Sep 25, 2024
@c8y3 c8y3 linked an issue Sep 25, 2024 that may be closed by this pull request
[FR] REST API v2.1.0: GET /api/v2/cases/{identifier}/iocs #537
Open
@c8y3 c8y3 requested a review from whikernel September 27, 2024 06:38
@whikernel whikernel merged commit adbd5a5 into develop Sep 27, 2024
6 checks passed
@c8y3 c8y3 deleted the rest_finalization branch September 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whikernel whikernel Awaiting requested review from whikernel

Assignees
No one assigned
Labels
enhancement New feature or request quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] REST API v2.1.0: GET /api/v2/cases/{identifier}/iocs
2 participants
@c8y3 @whikernel