Avoid crash on useless config parameters (#470)

dgarage · Nov 28, 2024 · 9721474 · 9721474
1 parent 3e0b204
commit 9721474
Showing 1 changed file with 1 addition and 13 deletions.
diff --git a/NBXplorer/Configuration/ExplorerConfiguration.cs b/NBXplorer/Configuration/ExplorerConfiguration.cs
@@ -204,7 +204,7 @@ public ExplorerConfiguration LoadArgs(IConfiguration config)
 
 			var obsolete = string.Join(", ",
 				new[] { "dbtrie", "automigrate", "nomigrateevts", "nomigraterawtxs", "cachechain", "deleteaftermigration", "dbcache" }
-				.Where(o => TryGetOrDefault<bool>(config, o, false)));
+				.Where(o => !string.IsNullOrEmpty(config[o])));
 
 			if (obsolete != string.Empty)
 			{
@@ -216,18 +216,6 @@ public ExplorerConfiguration LoadArgs(IConfiguration config)
 			return this;
 		}
 
-		private T TryGetOrDefault<T>(IConfiguration conf, string key, T defaultValue)
-		{
-			try
-			{
-				return conf.GetOrDefault<T>(key, defaultValue);
-			}
-			catch
-			{
-				return defaultValue;
-			}
-		}
-
 		private int GetPort(EndPoint nodeEndpoint)
 		{
 			if (nodeEndpoint is IPEndPoint endPoint)