using Set in trackers map

dgirardi · Aug 31, 2023 · cb593d5 · cb593d5
1 parent 641c597
commit cb593d5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/video.js b/src/video.js
@@ -118,17 +118,17 @@ function isValidVastTracker(trackers, trackerToAdd) {
 
 function trackersToMap(trackers) {
   return trackers.reduce((map, {url, event}) => {
-    !map.has(event) && map.set(event, [])
-    map.get(event).push(url);
+    !map.has(event) && map.set(event, new Set())
+    map.get(event).add(url);
     return map;
   }, new Map())
 }
 
 export function addImpUrlToTrackers(bid, trackersMap) {
   if (bid.vastImpUrl) {
     if (!trackersMap) { trackersMap = new Map(); }
-    if (!trackersMap.get('impressions')) { trackersMap.set('impressions', []); }
-    trackersMap.get('impressions').push(bid.vastImpUrl);
+    if (!trackersMap.get('impressions')) { trackersMap.set('impressions', new Set()); }
+    trackersMap.get('impressions').add(bid.vastImpUrl);
   }
   return trackersMap;
 }
diff --git a/test/spec/video_spec.js b/test/spec/video_spec.js
@@ -114,7 +114,7 @@ describe('video.js', function () {
     trackers = getVastTrackers({'cpm': 1.0});
     expect(trackers).to.be.a('map');
     expect(trackers.get('impressions')).to.exists;
-    expect(trackers.get('impressions')[0]).to.equal('https://vasttracking.mydomain.com/vast?cpm=1');
+    expect(trackers.get('impressions').has('https://vasttracking.mydomain.com/vast?cpm=1')).to.be.true;
   });
 
   it('insert trackers in vastXml', function() {
@@ -128,6 +128,6 @@ describe('video.js', function () {
     const trackers = addImpUrlToTrackers({'vastImpUrl': 'imptracker.com'}, getVastTrackers({'cpm': 1.0}));
     expect(trackers).to.be.a('map');
     expect(trackers.get('impressions')).to.exists;
-    expect(trackers.get('impressions')[1]).to.equal('imptracker.com');
+    expect(trackers.get('impressions').has('imptracker.com')).to.be.true;
   });
 });