Zeta global ssp bid adapter: add shortname param (prebid#8454)

* zeta_global_sspBidAdapter shortname was added * remove the trash Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
dgirardi · May 24, 2022 · f11bcda · f11bcda
1 parent c434889
commit f11bcda
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 25 deletions.
diff --git a/modules/zeta_global_sspBidAdapter.js b/modules/zeta_global_sspBidAdapter.js
@@ -99,7 +99,7 @@ export const spec = {
       user: params.user ? params.user : {},
       app: params.app ? params.app : {},
       ext: {
-        tags: params.tags ? params.tags : {},
+        tags: {...params.tags, shortname: params.shortname},
         sid: params.sid ? params.sid : undefined
       }
     };

diff --git a/test/spec/modules/zeta_global_sspBidAdapter_spec.js b/test/spec/modules/zeta_global_sspBidAdapter_spec.js
@@ -25,6 +25,25 @@ describe('Zeta Ssp Bid Adapter', function () {
     }
   ];
 
+  const params = {
+    user: {
+      uid: 222,
+      buyeruid: 333
+    },
+    tags: {
+      someTag: 444,
+    },
+    sid: 'publisherId',
+    shortname: 'test_shortname',
+    site: {
+      page: 'testPage'
+    },
+    app: {
+      bundle: 'testBundle'
+    },
+    test: 1
+  };
+
   const bannerRequest = [{
     bidId: 12345,
     auctionId: 67890,
@@ -41,18 +60,7 @@ describe('Zeta Ssp Bid Adapter', function () {
       consentString: 'consentString'
     },
     uspConsent: 'someCCPAString',
-    params: {
-      placement: 111,
-      user: {
-        uid: 222,
-        buyeruid: 333
-      },
-      tags: {
-        someTag: 444,
-        sid: 'publisherId'
-      },
-      test: 1
-    },
+    params: params,
     userIdAsEids: eids
   }];
 
@@ -72,18 +80,7 @@ describe('Zeta Ssp Bid Adapter', function () {
     refererInfo: {
       referer: 'http://www.zetaglobal.com/page?param=video'
     },
-    params: {
-      placement: 111,
-      user: {
-        uid: 222,
-        buyeruid: 333
-      },
-      tags: {
-        someTag: 444,
-        sid: 'publisherId'
-      },
-      test: 1
-    },
+    params: params
   }];
 
   it('Test the bid validation function', function () {
@@ -269,4 +266,20 @@ describe('Zeta Ssp Bid Adapter', function () {
 
     expect(payload.imp[0].banner).to.be.undefined;
   });
+
+  it('Test required params in banner request', function () {
+    const request = spec.buildRequests(bannerRequest, bannerRequest[0]);
+    const payload = JSON.parse(request.data);
+    expect(payload.ext.sid).to.eql('publisherId');
+    expect(payload.ext.tags.someTag).to.eql(444);
+    expect(payload.ext.tags.shortname).to.eql('test_shortname');
+  });
+
+  it('Test required params in video request', function () {
+    const request = spec.buildRequests(videoRequest, videoRequest[0]);
+    const payload = JSON.parse(request.data);
+    expect(payload.ext.sid).to.eql('publisherId');
+    expect(payload.ext.tags.someTag).to.eql(444);
+    expect(payload.ext.tags.shortname).to.eql('test_shortname');
+  });
 });