CID never created if Zero stops early after first init (cherry pick to release/v20.07) #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created common function for proposing a new cid * checking for CID in entries * checking for CID in entries and proposing a new one if not found * changed a comment * proposing CID until there is no CID is assigned to it instead of proposing CID infinitely (useful in the case when a restarted node is joining a cluster) (cherry picked from commit 09ef988)
antblood
changed the title
martinmr
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
martinmr
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
|
#6637 was merged. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When we early(within 1s) stop a fresh dgraph zero. The CID is never assigned.
Changes:
Earlier when the dgraph zero wasn't started fresh, it was assumed that the CID is present in the entries.
Now I'm checking whether there's a CID is present in the entries on a restart. If it is present then that one is used, else a new CID is proposed.
Fixes DGRAPH-604
(cherry picked from commit 09ef988)
This change is
Docs Preview: