Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID never created if Zero stops early after first init (cherry pick to release/v20.07) #6209

Closed
wants to merge 1 commit into from

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Aug 17, 2020

Problem:

When we early(within 1s) stop a fresh dgraph zero. The CID is never assigned.

Changes:

Earlier when the dgraph zero wasn't started fresh, it was assumed that the CID is present in the entries.
Now I'm checking whether there's a CID is present in the entries on a restart. If it is present then that one is used, else a new CID is proposed.

Fixes DGRAPH-604
(cherry picked from commit 09ef988)


This change is Reviewable

Docs Preview: Dgraph Preview

* created common function for proposing a new cid

* checking for CID in entries

* checking for CID in entries and proposing a new one if not found

* changed a comment

* proposing CID until there is no CID is assigned to it instead of proposing CID infinitely (useful in the case when a restarted node is joining a cluster)

(cherry picked from commit 09ef988)
@antblood antblood changed the title CID never created if Zero stops early after first init (#5719) CID never created if Zero stops early after first init (cherry pick to release/v20.07) Aug 17, 2020
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

@danielmai
Copy link
Contributor

#6637 was merged. Closing this one.

@danielmai danielmai closed this Nov 7, 2020
@joshua-goldstein joshua-goldstein deleted the joaquin/v20.07-CID_not_assigned branch August 18, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants