Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec requirement from = 2.3.0 to = 2.4.0 #414

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2021

Updates the requirements on rubocop-rspec to permit the latest version.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.4.0

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). (@​topalovic)
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. (@​tejasbubane)
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. (@​rrosenblum)
  • Add new RSpec/IdenticalEqualityAssertion cop. (@​tejasbubane)
  • Add RSpec/Rails/AvoidSetupHook cop. (@​paydaylight)
  • Fix false negative in RSpec/ExpectChange cop with block style and chained method call. (@​tejasbubane)
Changelog

Sourced from rubocop-rspec's changelog.

2.4.0 (2021-06-09)

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). ([@​topalovic][])
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. ([@​tejasbubane][])
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. ([@​rrosenblum][])
  • Add new RSpec/IdenticalEqualityAssertion cop. ([@​tejasbubane][])
  • Add RSpec/Rails/AvoidSetupHook cop. ([@​paydaylight][])
  • Fix false negative in RSpec/ExpectChange cop with block style and chained method call. ([@​tejasbubane][])

2.3.0 (2021-04-28)

  • Allow RSpec/ContextWording to accept multi-word prefixes. ([@​hosamaly][])
  • Drop support for ruby 2.4. ([@​bquorning][])
  • Add CountAsOne configuration option to RSpec/ExampleLength. ([@​stephannv][])
  • Fix a false positive for RSpec/RepeatedExampleGroupBody when pending or skip have argument(s). ([@​Tietew][])

2.2.0 (2021-02-02)

  • Fix HooksBeforeExamples, LeadingSubject, LetBeforeExamples and ScatteredLet autocorrection to take into account inline comments and comments immediately before the moved node. ([@​Darhazer][])
  • Improve rubocop-rspec performance. ([@​Darhazer][], [@​bquorning][])
  • Include Enabled: true to prevent a mismatched configuration parameter warning when RSpec cops are explicitly enabled in the user configuration. ([@​pirj][])

2.1.0 (2020-12-17)

  • Fix RSpec/FilePath false positive for relative file path runs with long namespaces. ([@​ahukkanen][])
  • Update RSpec/Focus to have auto-correction. ([@​dvandersluis][])

2.0.1 (2020-12-02)

  • Fixed infinite loop in RSpec/ExpectActual autocorrection when both expected and actual values are literals. ([@​Darhazer][])

2.0.0 (2020-11-06)

  • Remove deprecated class ::RuboCop::Cop::RSpec::Cop. ([@​bquorning][])
  • Retire RSpec/InvalidPredicateMatcher cop. ([@​pirj][])
  • Remove the code responsible for filtering files to inspect. ([@​pirj][])
  • Make RSpec language elements configurable. ([@​sl4vr][])
  • Remove CustomIncludeMethods RSpec/EmptyExampleGroup option in favour of the new RSpec DSL configuration. ([@​pirj][])
  • Enabled pending cop (RSpec/StubbedMock). ([@​pirj][])

2.0.0.pre (2020-10-22)

  • Update RuboCop dependency to v1.0.0. ([@​bquorning][])
  • Change namespace of several cops (Capybara/* -> RSpec/Capybara/*, FactoryBot/* -> RSpec/FactoryBot/*, Rails/* -> RSpec/Rails/*). ([@​pirj][], [@​bquorning][])

1.44.1 (2020-10-20)

1.44.0 (2020-10-20)

... (truncated)

Commits
  • 1b360e5 Merge pull request #1159 from rubocop/release
  • b82febd Bump version to 2.4.0
  • 2d00dbb Merge pull request #1158 from topalovic/file-path-check-suffix-for-non-const
  • c4646ff Make FilePath check suffix when given a non-const top-level node
  • 0be6148 Merge pull request #1152 from tejasbubane/fix-1143
  • 0cbc140 Add more specs for RSpec/ExpectChange
  • c3dd64a Fix false negative in RSpec/ExpectChange cop with block style and chained m...
  • 9e55194 Merge pull request #1133 from paydaylight/add-prefer-before-over-setup-cop
  • e94b463 Add RSpec/Rails/AvoidSetupHook cop
  • e0e109c Merge pull request #1132 from tejasbubane/fix-1130
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #414 (d1a17ea) into master (0736fd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          50       50           
  Lines        1460     1460           
=======================================
  Hits         1253     1253           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0736fd7...d1a17ea. Read the comment docs.

@dgroup dgroup added this to the 0.9.3 milestone Jun 28, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-eq-2.4.0 branch from d1a17ea to b292cd0 Compare June 28, 2021 08:23
Updates the requirements on [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-eq-2.4.0 branch from b292cd0 to 27bda55 Compare June 28, 2021 08:23
@dgroup
Copy link
Owner

dgroup commented Jun 28, 2021

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 28, 2021

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jun 28, 2021

@rultor merge

@dependabot[bot] @dgroup Oops, I failed. You can see the full log here (spent 5min)

  test_cc_has_valid_email                                        \u001b[32m PASS\u001b[0m (0.00s)
  test_cc_has_valid_email_despite_on_unexpected_symbols          \u001b[32m PASS\u001b[0m (0.00s)
  test_cc_has_valid_emails                                       \u001b[32m PASS\u001b[0m (0.00s)
  test_cc_has_valid_email_despite_on_additional_spaces           \u001b[32m PASS\u001b[0m (0.00s)

Lazylead::OnlyLLTest
  test_email_notification                                        \u001b[32m PASS\u001b[0m (1.37s)
  test_multiple_scores_in_the_same_ticket                        \u001b[32m PASS\u001b[0m (0.00s)
  test_sort_of_percents                                          \u001b[32m PASS\u001b[0m (0.00s)
  test_violators_should_consider_already_existing_LL_grid_labels \u001b[32m PASS\u001b[0m (0.00s)
  test_grid_label_found                                          \u001b[32m PASS\u001b[0m (1.38s)
  test_grid_label_set_by_ll                                      \u001b[32m PASS\u001b[0m (1.58s)
  test_ensure_that_violators_found                               \u001b[32m PASS\u001b[0m (0.00s)
  test_detect_score                                              \u001b[32m PASS\u001b[0m (1.55s)

Lazylead::MicromanagerTest
  test_alert_in_case_duedate_changed_by_not_authorized_person    \u001b[32m PASS\u001b[0m (1.11s)
  test_since_for_past_1_min                                      \u001b[32m PASS\u001b[0m (0.00s)

Lazylead::ExchangeTest
  test_exchange_email_with_attachment                            \u001b[33m SKIP\u001b[0m (0.00s)
  test_email_notification_to_outlook_exchange                    \u001b[33m SKIP\u001b[0m (0.00s)
  test_exchange_email_notification_using_decrypted_credentials   \u001b[33m SKIP\u001b[0m (0.00s)

Lazylead::WikiTest
  test_wiki_reference_is_present                                 \u001b[32m PASS\u001b[0m (0.00s)

Finished in 78.84915s
178 tests, 381 assertions, \u001b[32m0 failures, 0 errors, \u001b[0m\u001b[33m12 skips\u001b[0m
Coverage report generated for Unit Tests to /home/r/repo/coverage. 1253 / 1460 LOC (85.82%) covered.
Running RuboCop...
Inspecting 101 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

101 files inspected, \u001b[32mno offenses\u001b[0m detected
Running sqlint...
Inspecting 2 files
2 files inspected, \u001b[0;32;49mno offenses\u001b[0m detected
Running xcop...
Inspecting 0 files...

0 files checked, everything looks \u001b[32mpretty\u001b[0m
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
To git@github.com:dgroup/lazylead.git
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'git@github.com:dgroup/lazylead.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container aad08ebb264d95c71ce3b4588894a21457e521b1e300cfcc7f467c07fd063d47 is dead
Mon Jun 28 10:33:45 CEST 2021

@dgroup dgroup modified the milestones: 0.9.3, 0.10.0 Jul 6, 2021
@dgroup dgroup merged commit ea73339 into master Jul 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/bundler/rubocop-rspec-eq-2.4.0 branch July 6, 2021 19:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants