Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from = 1.23.0 to = 1.24.1 #551

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.24.1

Bug fixes

  • #10313: Fix autocorrect Style/MapToHash with multiline code. (@​tejasbubane)
  • #10251: Fix an incorrect autocorrect for Gemspec/RequireMFA when .gemspec file contains metadata keys assignments. (@​fatkodima)
  • #10329: Fix a false positive for Lint/ParenthesesAsGroupedExpression and an incorrect autocorrect for the cop with Style/TernaryParentheses when using ternary expression as a first argument. (@​koic)
  • #10317: Fix a false positive for Style/MethodCallWithArgsParentheses when using hash value omission. (@​koic)
  • #10333: Fix an incorrect autocorrect for Naming/BlockForwarding using explicit block forwarding without method definition parentheses. (@​koic)
  • #10321: Make Style/MethodDefParentheses aware of Ruby 3.1's anonymous block forwarding. (@​koic)
  • #10320: Fix an incorrect autocorrect for Style/FileWrite when using heredoc argument. (@​koic)
  • #10319: Require rubocop-ast 1.15.1 to fix a false positive for Style/CombinableLoop when the same method with different arguments and safe navigation. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.24.1 (2021-12-31)

Bug fixes

  • #10313: Fix autocorrect Style/MapToHash with multiline code. ([@​tejasbubane][])
  • #10251: Fix an incorrect autocorrect for Gemspec/RequireMFA when .gemspec file contains metadata keys assignments. ([@​fatkodima][])
  • #10329: Fix a false positive for Lint/ParenthesesAsGroupedExpression and an incorrect autocorrect for the cop with Style/TernaryParentheses when using ternary expression as a first argument. ([@​koic][])
  • #10317: Fix a false positive for Style/MethodCallWithArgsParentheses when using hash value omission. ([@​koic][])
  • #10333: Fix an incorrect autocorrect for Naming/BlockForwarding using explicit block forwarding without method definition parentheses. ([@​koic][])
  • #10321: Make Style/MethodDefParentheses aware of Ruby 3.1's anonymous block forwarding. ([@​koic][])
  • #10320: Fix an incorrect autocorrect for Style/FileWrite when using heredoc argument. ([@​koic][])
  • #10319: Require rubocop-ast 1.15.1 to fix a false positive for Style/CombinableLoop when the same method with different arguments and safe navigation. ([@​koic][])

1.24.0 (2021-12-23)

New features

  • #10279: Support Ruby 3.1's anonymous block forwarding syntax. ([@​koic][])
  • #10295: Support Ruby 3.1's hash value omission syntax for Layout/HashAlignment. ([@​koic][])
  • #10303: Add AllowedNumbers option to Style/NumericLiterals. ([@​koic][])
  • #10290: Add new Naming/BlockForwarding cop. ([@​koic][])
  • #10289: Add EnforcedShorthandSyntax option to Style/HashSyntax cop to support Ruby 3.1's hash value omission syntax by default. ([@​koic][])
  • #10257: Add new Style/MapToHash cop. ([@​dvandersluis][])
  • #10261: Add new Style/FileRead cop. ([@​leoarnold][])
  • #10291: Support Ruby 3.1's hash value omission syntax for Layout/SpaceAfterColon. ([@​koic][])
  • #10260: Add new Style/FileWrite cop. ([@​leoarnold][])
  • #10307: Support Ruby 2.7's numbered parameter for Metrics/BlockLength, Metrics/ClassLength, Metrics/MethodLength, and Metrics/ModuleLength cops. ([@​koic][])
  • #7671: Add cli option --show-docs-url to print out documentation url for given cops. ([@​HeroProtagonist][])
  • #10308: Make Style/CollectionCompact aware of block pass argument. ([@​koic][])

Bug fixes

  • #10285: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested if within if foo = bar. ([@​koic][])
  • #10309: Fix a false positive for Bundler/DuplicatedGem when a gem conditionally duplicated within multi-statement bodies. ([@​fatkodima][])
  • #10300: Fix an incorrect autocorrect for Layout/DotPosition and Style/RedundantSelf when auto-correction conflicts. ([@​koic][])
  • #10284: Fix an incorrect autocorrect for Style/RedundantRegexpCharacterClass when regexp containing an unescaped #. ([@​koic][])
  • #10265: Fix Style/IfInsideElse to be able to handle if-then nested inside an else without clobbering. ([@​dvandersluis][])
  • #10297: Fix a false positive for Lint/DeprecatedOpenSSLConstant when building digest using an algorithm string and nested digest constants. ([@​koic][])
  • #10282: Fix an incorrect autocorrect for Style/EmptyCaseCondition when using when ... then in case in a method call. ([@​koic][])
  • #10273: Fix a false positive for InternalAffairs/UndefinedConfig to suppress a false wrong namespace warning. ([@​koic][])
  • #10305: Fix an incorrect autocorrect for Style/HashConversion when using Hash[a || b]. ([@​koic][])
  • #10264: Fix the following incorrect auto-correct for Style/MethodCallWithArgsParentheses with Layout/SpaceBeforeFirstArg. ([@​koic][])
  • #10276: Fix an incorrect autocorrect for Style/RedundantInterpolation when using a method call without parentheses in string interpolation. ([@​koic][])

Changes

  • #10253: Deprecate RuboCop::Cop::EnforceSuperclass module. ([@​koic][])
  • #10248: Make Lint/DeprecatedClassMethods aware of ENV.freeze. ([@​koic][])
  • #10269: Mark Lint/IncompatibleIoSelectWithFiberScheduler as unsafe auto-correction. ([@​koic][])
  • #8586: Add configuration parameter AllowForAlignment in Layout/CommentIndentation. ([@​jonas054][])

... (truncated)

Commits
  • 0c0bee1 Cut 1.24.1
  • b864ea3 Update Changelog
  • ced2bbd Fix an incorrect autocorrect for Naming/BlockForwarding
  • dc4ce59 Remove dead SemVer compatibility badge
  • 41234cb [Fix #10329] Fix a false positive for Lint/ParenthesesAsGroupedExpression
  • 5290c6e Fix an incorrect autocorrect for Gemspec/RequireMFA when .gemspec file cont...
  • 6821569 [Fix #10321] Make Style/MethodDefParentheses aware of anonymous block forwa...
  • 883bf10 [Fix #10317] Fix a false positive for Style/MethodCallWithArgsParentheses
  • 8ce1e7c Use call instead of {send csend} for def_node_matcher
  • 3ffa2bc Merge pull request #10326 from koic/use_cimg_instead_of_deprecated_circleci_i...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 3, 2022
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.23.0...v1.24.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-eq-1.24.1 branch from 8492e7f to 4d6588f Compare January 6, 2022 02:24
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dgroup
Copy link
Owner

dgroup commented Jan 6, 2022

@rultor merge

@dgroup dgroup added this to the 0.12.0 milestone Jan 6, 2022
@rultor
Copy link
Collaborator

rultor commented Jan 6, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 6, 2022

@rultor merge

@dependabot[bot] @dgroup Oops, I failed. You can see the full log here (spent 4min)

Lazylead::JiraTest
  test_convert_column_to_json                                    \u001b[32m PASS\u001b[0m (4.38s)
Lazylead::JiraTest
  test_alert_in_case_missing_comment                             \u001b[32m PASS\u001b[0m (1.55s)
Lazylead::JiraTest
  test_task_properties_are_using_ENV_variables                   \u001b[32m PASS\u001b[0m (4.38s)
Lazylead::JiraTest
  test_postman_initiated_through_orm                             \u001b[32m PASS\u001b[0m (4.74s)
Lazylead::JiraTest
  test_env_properties_injected                                   \u001b[32m PASS\u001b[0m (4.57s)
Lazylead::JiraTest
  test_issue_history_not_found                                   \u001b[32m PASS\u001b[0m (0.83s)
Lazylead::JiraTest
  test_task_properties_are_parsed_despite_on_wrong_config        \u001b[32m PASS\u001b[0m (4.72s)
Lazylead::JiraTest
  test_issue_url_fetched_successfully                            \u001b[32m PASS\u001b[0m (0.57s)
Lazylead::JiraTest
  test_found_issue_by_jira_(ORM)                                 \u001b[33m SKIP\u001b[0m (0.00s)
Lazylead::JiraTest
  test_found_issue_by_id                                         \u001b[32m PASS\u001b[0m (0.83s)
Lazylead::JiraTest
  test_second_ticketing_system_is_found                          \u001b[32m PASS\u001b[0m (4.96s)
Lazylead::JiraTest
  test_labels_found                                              \u001b[32m PASS\u001b[0m (0.82s)
Lazylead::JiraTest
  test_issue_has_1_field                                         \u001b[32m PASS\u001b[0m (0.57s)
Lazylead::JiraTest
  test_field_found                                               \u001b[32m PASS\u001b[0m (0.82s)
Lazylead::JiraTest
  test_make_an_jira_comment                                      \u001b[32m PASS\u001b[0m (0.00s)
Lazylead::JiraTest
  test_component_is_correct                                      \u001b[32m PASS\u001b[0m (0.82s)
Lazylead::JiraTest
  test_sprint_is_found                                           \u001b[32m PASS\u001b[0m (0.82s)
  test_construct_accuracy_from_orm                               \u001b[32m PASS\u001b[0m (4.14s)
Lazylead::JiraTest
  test_group_by_assignee                                         \u001b[32m PASS\u001b[0m (0.92s)
  test_issue_has_expected_status                                 \u001b[32m PASS\u001b[0m (0.82s)
  test_detect_plain_cc                                           \u001b[32m PASS\u001b[0m (3.59s)
  test_detect_complex_cc_by_predefined_component                 \u001b[32m PASS\u001b[0m (4.11s)
  test_issue_reporter_fetched_successfully                       \u001b[32m PASS\u001b[0m (0.82s)
  test_issue_history_found                                       \u001b[32m PASS\u001b[0m (0.90s)
  test_connected_based_on_string_properties                      \u001b[32m PASS\u001b[0m (0.82s)
  test_bulk_search_in_few_iterations                             \u001b[32m PASS\u001b[0m (1.41s)
  test_description_is_correct                                    \u001b[32m PASS\u001b[0m (0.84s)
  test_field_not_found                                           \u001b[32m PASS\u001b[0m (0.83s)
  test_bulk_search_in_few_iterations_with_limit                  \u001b[32m PASS\u001b[0m (1.66s)

Finished in 8.73671s
213 tests, 425 assertions, \u001b[31m0 failures, 1 errors, \u001b[0m\u001b[33m12 skips\u001b[0m
Coverage report generated for Unit Tests, Unit Tests-0, Unit Tests-1, Unit Tests-10, Unit Tests-11, Unit Tests-2, Unit Tests-3, Unit Tests-4, Unit Tests-5, Unit Tests-6, Unit Tests-7, Unit Tests-8, Unit Tests-9 to /home/r/repo/coverage. 1414 / 1633 LOC (86.59%) covered.
rake aborted!
Command failed with status (1): [ruby -I"lib:test:lib" /home/r/.ruby/gems/rake-13.0.6/lib/rake/rake_test_loader.rb "test/lazylead/allocated_test.rb" "test/lazylead/cc_test.rb" "test/lazylead/cli/app_test.rb" "test/lazylead/confluence_test.rb" "test/lazylead/exchange_test.rb" "test/lazylead/file_postman_test.rb" "test/lazylead/model_test.rb" "test/lazylead/opts_test.rb" "test/lazylead/postman_test.rb" "test/lazylead/retry_test.rb" "test/lazylead/salt_test.rb" "test/lazylead/smoke_test.rb" "test/lazylead/smtp_test.rb" "test/lazylead/stdout_postman_test.rb" "test/lazylead/system/jira_test.rb" "test/lazylead/task/accuracy/accuracy_test.rb" "test/lazylead/task/accuracy/affected_build_test.rb" "test/lazylead/task/accuracy/attachment_test.rb" "test/lazylead/task/accuracy/environment_test.rb" "test/lazylead/task/accuracy/has_label_test.rb" "test/lazylead/task/accuracy/logs_link_test.rb" "test/lazylead/task/accuracy/logs_test.rb" "test/lazylead/task/accuracy/memes_test.rb" "test/lazylead/task/accuracy/onlyll_test.rb" "test/lazylead/task/accuracy/records_llink_test.rb" "test/lazylead/task/accuracy/records_test.rb" "test/lazylead/task/accuracy/score_test.rb" "test/lazylead/task/accuracy/screenshots_test.rb" "test/lazylead/task/accuracy/servers_test.rb" "test/lazylead/task/accuracy/stacktrace_test.rb" "test/lazylead/task/accuracy/testcase_test.rb" "test/lazylead/task/accuracy/wiki_test.rb" "test/lazylead/task/accuracy/wiki_url_test.rb" "test/lazylead/task/alert/alertif_test.rb" "test/lazylead/task/alert/assignee_alert_test.rb" "test/lazylead/task/alert/changed_to_test.rb" "test/lazylead/task/assignment_test.rb" "test/lazylead/task/confluence_ref_test.rb" "test/lazylead/task/created_recently_test.rb" "test/lazylead/task/duedate_test.rb" "test/lazylead/task/echo_test.rb" "test/lazylead/task/fix_version_test.rb" "test/lazylead/task/loading_test.rb" "test/lazylead/task/micromanager_test.rb" "test/lazylead/task/missing_comment_test.rb" "test/lazylead/task/propagate_down_test.rb" "test/lazylead/task/savepoint_test.rb" "test/lazylead/task/svn/diff_test.rb" "test/lazylead/task/svn/grep_test.rb" "test/lazylead/task/svn/touch_test.rb" "test/lazylead/version_test.rb" "test/sqlite_test.rb" ]
/home/r/.ruby/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)
container cbaa164987b1ca8e45f38c2828480fabcfa415d425510143f394ce30a7ac65aa is dead
Thu Jan  6 03:31:20 CET 2022

@dgroup dgroup merged commit e0a6301 into master Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependabot/bundler/rubocop-eq-1.24.1 branch January 17, 2022 18:43
@dgroup dgroup modified the milestone: 0.12.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants