Drop support for old encodings #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back we dropped the standard version from the binary encoding, but we still wrote out old binary encodings for backwards compatibility. However, by this point there are likely very few people using the old encodings by this point and they should upgrade anyway. The upside of dropping support for older encodings (besides simpler code), is that now binary cache writes will be 6x faster since we don't need to write out the same cache product 5 extra times for older encodings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back we dropped the standard version from the binary encoding,
but we still wrote out old binary encodings for backwards compatibility.
However, by this point there are likely very few people using the old
encodings by this point and they should upgrade anyway.
The upside of dropping support for older encodings (besides simpler
code), is that now binary cache writes will be 6x faster since we
don't need to write out the same cache product 5 extra times for older
encodings.