Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromDhall instances for Contravariant functors #2278

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

locallycompact
Copy link
Contributor

@locallycompact locallycompact commented Aug 14, 2021

No description provided.

@locallycompact locallycompact changed the title Add FromDhall instance for Contravariant functors: Predicate, Equival… Add FromDhall instances for Contravariant functors Aug 14, 2021
@Gabriella439
Copy link
Collaborator

It looks like this will require enabling the StandaloneDeriving and DerivingStrategies language extensions

@Gabriella439
Copy link
Collaborator

Hmmm, for some weird reason it looks it is complaining about missing haddocks for the re-exported types. One way to fix this is to change this regex to be more specific:

! (./Setup haddock 2>&1 | grep --quiet 'Missing documentation for:\|Warning:.*is out of scope') || (echo "Error: Incomplete haddocks"; exit 1)

… but it will probably simpler to not re-export the type that is missing haddocks

@Gabriella439 Gabriella439 merged commit 2366f40 into dhall-lang:master Aug 15, 2021
@Gabriella439
Copy link
Collaborator

@locallycompact: Thank you for contributing this! 🙂

@sjakobi sjakobi mentioned this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants