Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromDhall / ToDhall instances for temporal values #2294

Merged
merged 4 commits into from
Sep 2, 2021
Merged

FromDhall / ToDhall instances for temporal values #2294

merged 4 commits into from
Sep 2, 2021

Conversation

Gabriella439
Copy link
Collaborator

Fixes #2286

@Gabriella439 Gabriella439 mentioned this pull request Aug 24, 2021
Closed
sjakobi
sjakobi reviewed Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the PR title mentions FromDhall instances but that the patch doesn't actually add any. Did you change your mind about adding such instances?

@Gabriella439
Copy link
Collaborator Author

Gabriella439 commented Aug 26, 2021 •
edited
Loading

Whoops! That was an oversight on my part. I did intend to add FromDhall instances, but forgot. I'll fix that

@mergify mergify bot merged commit 8ab5529 into master Sep 2, 2021
@mergify mergify bot deleted the gabriel/marshal_temporal branch September 2, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FromDhall/ToDhall for types from time?
2 participants
@Gabriella439 @sjakobi