Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromDhall instances for Int{,8,16,32,64} #2349

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

jchia
Copy link
Contributor

@jchia jchia commented Dec 10, 2021

@Gabriella439
Copy link
Collaborator

It looks like you will also need to fix this now that Dhall.Marshall.Internal re-exports Int{8,16,32,64}:

src/Dhall/Marshal/Decode.hs:149:1: error: [-Wunused-imports, -Werror=unused-imports]
    The import of ‘Data.Int’ is redundant
      except perhaps to import instances from ‘Data.Int’
    To import instances alone, use: import Data.Int()
    |
149 | import Data.Int                         (Int16, Int32, Int64, Int8)
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@jchia
Copy link
Contributor Author

jchia commented Dec 11, 2021

Fixed.

@Gabriella439 Gabriella439 merged commit c616a62 into dhall-lang:master Dec 11, 2021
@Gabriella439
Copy link
Collaborator

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants