Fix i128_support in range.rs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I broke the benchmarks while removing the |
dhardy
reviewed
Oct 19, 2017
benches/distributions.rs
Outdated
| ($fnn:ident, $ty:ty, $low:expr, $high:expr) => { | ||
| #[bench] | ||
| fn $fnn(b: &mut Bencher) { | ||
| let mut rng = XorShiftRng::new().unwrap(); | ||
| let distr = range2::Range::new($low, $high); | ||
| let distr = range::Range::new($low, $high); |
There was a problem hiding this comment.
This can probably be just Range::new now. IIRC the only reason for the prefix was because to avoid confusion with the old range::Range.
pitdicker
force-pushed
the
fix_i128_support
branch
from
7b9f952
to
2e714f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke
i128_support...