fix tree corruption upon delete then insert #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data corruption is due to the fact that entries of different nodes share the same slice. For example, assume nodeA.entries == buf[:3] nodeB.entries == buf[3:] when we do nodeA.entries = append(nodeA.entries, foo) we accidentally make nodeB.entries[0] == foo and nodeB's data is corrupted. This issue is likely the cause behind #28
|
This is great! Thank you! |
dhconnelly
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data corruption is due to the fact that entries of different nodes share the same slice.
For example, assume
nodeA.entries == buf[:3]
nodeB.entries == buf[3:]
when we do
nodeA.entries = append(nodeA.entries, foo)
we accidentally make nodeB.entries[0] == foo
and nodeB's data is corrupted.
This issue is likely the cause behind
#28