optimize condenseTree and computeBoundingBox #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condenseTree contains memory allocations that when triggered causes the following time spent: runtime.mheap.alloc 39.27% Similarly, particular Delete heavy workloads might trigger unnecessary computeBoundingBox 16.57% This change fixes these performance issues.
dhconnelly
requested changes
Aug 18, 2022
|
looks good, just adding a couple of small comments would be helpful! |
Co-authored-by: Daniel Connelly <dhconnelly@gmail.com>
Applied the suggestions therein, thanks for the review. |
dhconnelly
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condenseTree contains memory allocations that when triggered causes the
following time spent:
runtime.mheap.alloc 39.27%
Similarly, particular Delete heavy workloads might trigger unnecessary
computeBoundingBox 16.57%
This change fixes these performance issues.