Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node 18 support #1615

Closed
webdeveric opened this issue Nov 18, 2022 · 1 comment · Fixed by #1616
Closed

Add Node 18 support #1615

webdeveric opened this issue Nov 18, 2022 · 1 comment · Fixed by #1616
Labels
feature

Comments

@webdeveric
Copy link
Contributor

Feature Request

Add nodejs18.x since Node 18 is now supported in AWS Lambdas.

serverless-offline/src/config/supportedRuntimes.js

Lines 17 to 21 in 6ab3928

export const supportedNodejs = new Set([
'nodejs12.x',
'nodejs14.x',
'nodejs16.x',
])

@dnalborczyk
Copy link
Collaborator

thank you for bringing this up @webdeveric ! could you create a PR for the addition?

@webdeveric webdeveric mentioned this issue Nov 18, 2022
Merged
dnalborczyk pushed a commit that referenced this issue Nov 18, 2022
@webdeveric
feat: Add support for nodejs18.x runtime (#1616)
accefa3 
Closes #1615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for nodejs18.x runtime webdeveric/serverless-offline
2 participants
@webdeveric @dnalborczyk