Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml 5.2 support #6

Closed
kit-ty-kate opened this issue Mar 5, 2024 · 3 comments · Fixed by #7
Closed

OCaml 5.2 support #6

kit-ty-kate opened this issue Mar 5, 2024 · 3 comments · Fixed by #7
Assignees
@dhil
Labels
bug Something isn't working enhancement New feature or request

Comments

@kit-ty-kate
Copy link

I'm opening this just to track the issue started in kayceesrk/delimcc_of_fxhandler#1

According to @dra27 ocaml/ocaml#12735 could be the culprit
@dhil
Copy link
Owner

dhil commented Mar 5, 2024

Thanks! I will try to dig into it later this week.

@dhil dhil self-assigned this Mar 5, 2024
@dhil
Copy link
Owner

dhil commented Mar 5, 2024 •
edited
Loading

After a quick glance, I think I may have identified the problem. This is mostly a note for myself:

Patch ocaml/ocaml#12735 changes the continuation into a pair (first stack segment, last stack segment) but https://github.com/dhil/ocaml-multicont/blob/master/lib/multicont_stubs.c#L39 returns a stack pointer (as a continuation).

The cloning operation needs to be changed accordingly.

@dhil dhil added bug Something isn't working enhancement New feature or request labels Mar 5, 2024
dhil added a commit that referenced this issue Mar 5, 2024
@dhil
OCaml 5.2 support
fa5b406 
This patch adds OCaml 5.2 support. The main change is to account for
the new continuation representation in OCaml 5.2, which represents a
continuation as a pair. Legacy support is preserved via the use of the
compile-time `MULTICONT52` variable. When toggled code for the new
continuation representation is included, otherwise this code is
excluded.

Resolves #6.
@dhil dhil mentioned this issue Mar 5, 2024
Merged
@dhil
Copy link
Owner

dhil commented Mar 5, 2024

Should be fixed by #7. Thanks again @kit-ty-kate.

@dhil dhil closed this as completed in #7 Mar 6, 2024
dhil added a commit that referenced this issue Mar 6, 2024
@dhil
OCaml 5.2 support (#7)
94dee45 
* OCaml 5.2 support

This patch adds OCaml 5.2 support. The main change is to account for
the new continuation representation in OCaml 5.2, which represents a
continuation as a pair. Legacy support is preserved via the use of the
compile-time `MULTICONT52` variable. When toggled code for the new
continuation representation is included, otherwise this code is
excluded.

Resolves #6.

* Use ocaml-5.2.0+trunk in CI until the proper release is available.

* Follow the OCaml manual's FFI rules even if they may not be strictly required.
@dhil dhil mentioned this issue Mar 6, 2024
Merged
dhil added a commit to dhil/opam-repository that referenced this issue Mar 7, 2024
@dhil
[new release] multicont (1.0.2)
2057f3a 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
dhil added a commit to dhil/opam-repository that referenced this issue Mar 7, 2024
@dhil
[new release] multicont (1.0.2)
55802d7 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
dhil added a commit to dhil/opam-repository that referenced this issue Mar 7, 2024
@dhil
[new release] multicont (1.0.2)
f0947f2 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
dhil added a commit to dhil/opam-repository that referenced this issue Mar 7, 2024
@dhil
[new release] multicont (1.0.2)
efd80e6 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
dhil added a commit to dhil/opam-repository that referenced this issue Mar 7, 2024
@dhil
[new release] multicont (1.0.2)
7e08e81 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
dhil added a commit to dhil/opam-repository that referenced this issue Mar 8, 2024
@dhil
[new release] multicont (1.0.2)
e5d2184 
CHANGES:

This release adds support for the anticipated release of OCaml 5.2.

Changes:

* Patch dhil/ocaml-multicont#7: OCaml 5.2 support (thanks to kit-ty-kate for the issue
  report dhil/ocaml-multicont#6; thanks to David Allsopp for reviewing the patch).  The
  change accounts for the new continuation representation.
* Added a basic testsuite runnable via `dune runtest`.
* Fixed a memory leak in the rollback parsing example.
* Added an entry about subtle interactions of unrestricted and linear
  effects in the "Cautionary tales" section of the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhil dhil

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OCaml 5.2 support dhil/ocaml-multicont
2 participants
@dhil @kit-ty-kate